Add 3.11 to images with newer openssl as needed #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
requested changes
Jan 29, 2025
rocky8/Dockerfile
Outdated
| # Compile newer version of python3 | ||
| RUN yum -y install openssl openssl-devel zlib-devel bzip2 bzip2-devel readline-devel tk-devel libffi-devel xz-devel && \ | ||
| cd ~ && \ | ||
| # Set up pyenv \ | ||
| git clone https://github.com/pyenv/pyenv.git ~/.pyenv && \ | ||
| pyenv install 3.10 && \ | ||
| # setup python 3.10 \ | ||
| PYTHON_CONFIGURE_OPTS="--enable-shared --enable-optimizations" pyenv install 3.10 && \ |
There was a problem hiding this comment.
do we want to be changing 3.10 configure options?
| # setup python 3.10 \ | ||
| PYTHON_CONFIGURE_OPTS="--enable-shared --enable-optimizations" pyenv install 3.10 && \ | ||
| # setup python 3.11 w/ openssl 3 \ | ||
| PYTHON_CONFIGURE_OPTS="--with-openssl=/usr/local/ssl --with-openssl-rpath=auto --enable-shared --enable-optimizations" pyenv install 3.11 && \ |
There was a problem hiding this comment.
review the details of optimizations specifically related to asserts being disabled
rocky8/Dockerfile
Outdated
| pyenv global 3.10 && \ | ||
| pip install --upgrade pip && \ | ||
| pip install --no-cache-dir py3createtorrent awscli && \ | ||
| python3 -c 'import sys; import sqlite3; sys.exit(sqlite3.sqlite_version != "3.40.1")' && \ | ||
| python3 -c 'import sys; import sqlite3; sys.exit(sqlite3.sqlite_version != "3.45.1")' && \ |
There was a problem hiding this comment.
do we want to be changing the sqlite version in 3.10? i know that it would be more hassle to have two versions. just make sure we plan accordingly.
emlowe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add python 3.11 to base images
Add openssl 3 to Ubuntu 20 and Rocky8 and use when building python 3.11
Use
enable-optimizationsfor python 3.11 which appears to be reasonable safe to use (see https://devguide.python.org/getting-started/setup-building/#optimization)removed any unneeded changes